Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: HEADER ONLY: buffer pool ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3688/2/be/src/bufferpool/buffer-pool.h File be/src/bufferpool/buffer-pool.h: Line 219: void DuplicateHandle(const PageHandle& src, Client* client, PageHandle* dst); Doesn't seem like we need this. Line 296: BufferHandle ExtractBuffer(); It'd be nice for this to live side-by-side with Pin() and Unpin() so either move this to BufferPool or move those Page operations here. My slight preference is to move this and leave Buffer/Page more like structs since the buffer pool is the thing that has to do the heavy lifting, but I'm okay either way. -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
