Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3201: HEADER ONLY: buffer pool ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3688/2/be/src/bufferpool/buffer-pool.h File be/src/bufferpool/buffer-pool.h: Line 303: uint8_t* buf() const; PageHandle should not have this function. all access of the underlying data needs to go through the buffer abstraction (otherwise you don't really have a separation of abstractions). algorithms that only implement data processing logic should only deal with buffers, whereas algorithms that only implement spilling-type logic should only deal with pages. -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
