Amos Bird has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/1563/9/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: Line 206: struct TShowFilesParams { > That's an interesting idea, but I don't think we should follow it. Ok. I think I should change all the ids to the partition's KV names and get the ids again in catalogd. Shall we take the global lock in this patch? http://gerrit.cloudera.org:8080/#/c/1563/9/fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java File fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java: Line 130: if (isKV_) { > Sorry for the confusion. I guess I needed to see the resulting code before Done Line 157: } > Shouldn't we have an else that throws here? Done -- To view, visit http://gerrit.cloudera.org:8080/1563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Amos Bird <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
