Alex Behm has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/1563/9/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: Line 206: struct TShowFilesParams { > Ok. I think I should change all the ids to the partition's KV names and get Sounds good. If you switch back to KVs then the proper locks should be take by the calls made in CatalogOpExecutor.java, so nothing needs to be added I think, but I will take another close look. -- To view, visit http://gerrit.cloudera.org:8080/1563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Amos Bird <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
