Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3311/9/be/src/util/coding-util.cc File be/src/util/coding-util.cc: Line 118: DCHECK(in_len <= std::numeric_limits<unsigned>::max()); i'd rather do if (UNLIKELY(in_len > ...)) return false; same for out_max -- To view, visit http://gerrit.cloudera.org:8080/3311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
