Yuanhao Luo has posted comments on this change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/3311/8/be/src/util/coding-util.cc File be/src/util/coding-util.cc: Line 118: const int encode_result = sasl_encode64(in, static_cast<unsigned>(in_len), out, > check in_len and out_max against max unsigned Already checked in Base64EncodeBufLen(), just see line 110 of this file. -- To view, visit http://gerrit.cloudera.org:8080/3311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica8f61fce7af16aa859f71d0763303e8d832ddcd Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
