Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-3905: Add HdfsScanner::GetNext() interface and 
implementation for Parquet.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3732/2/be/src/exec/hdfs-scan-node.cc
File be/src/exec/hdfs-scan-node.cc:

PS2, Line 270: ThreadTokenAvailableCb(runtime_state_->resource_pool());
Just curious, how would it help moving this out of AddDiskIoRanges() other than 
delay the spawning of scanner threads?


-- 
To view, visit http://gerrit.cloudera.org:8080/3732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab50770bac05afcda4d3404fb4f53a0104931eb0
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to