Alex Behm has posted comments on this change. Change subject: IMPALA-3905: Add HdfsScanner::GetNext() interface and implementation for Parquet. ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3732/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 302: assemble_rows_timer_ = &assemble_rows_timer; > I think we should avoid putting a pointer to the stack-allocated timer into Reverted back to the original solution. http://gerrit.cloudera.org:8080/#/c/3732/3/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS3, Line 373: CreateAndPrepareScanner > This should really be CreateAndOpenScanner() now. Nice catch. Done. http://gerrit.cloudera.org:8080/#/c/3732/3/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: Line 69: /// TODO(Alex): Change comments. > ? Forgot to remove, I addressed it :) -- To view, visit http://gerrit.cloudera.org:8080/3732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab50770bac05afcda4d3404fb4f53a0104931eb0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
