Alex Behm has posted comments on this change. Change subject: IMPALA-3915: Register privilege and audit requests when analyzing resolved table refs. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3783/2/fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java File fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java: PS2, Line 505: Adds audit events and privilege requests for : * the database and/or table. > Is this comment accurate now? Fixed. PS2, Line 2534: The given table must be a base table or a catalog view > What else could it be? Added comment. http://gerrit.cloudera.org:8080/#/c/3783/2/fe/src/main/java/com/cloudera/impala/analysis/CollectionTableRef.java File fe/src/main/java/com/cloudera/impala/analysis/CollectionTableRef.java: Line 46: * unresolved table ref. Sets the explicit alias and the join-related attributes > Maybe you want to comment where 'resolvedPath' is coming from. Done http://gerrit.cloudera.org:8080/#/c/3783/2/fe/src/main/java/com/cloudera/impala/analysis/FromClause.java File fe/src/main/java/com/cloudera/impala/analysis/FromClause.java: PS2, Line 21: import com.cloudera.impala.catalog.View; > I don't think this is used anywhere. Correct. Done. -- To view, visit http://gerrit.cloudera.org:8080/3783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18fa8af9a94ce190c5a3c29c3221c659a2ace659 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
