Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3915: Register privilege and audit requests when analyzing resolved table refs. ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3783/3//COMMIT_MSG Commit Message: PS3, Line 16: but since an InlineViewRef is : considered to be resolved, we never call TableRef.analyze(), and hence : never register an authorization event for the view. Maybe a dump idea but wouldn't it work if we just reset the resolvedPath of InliveViewRef, thereby forcing it to re-resolve the path and add the necessary priv checks? http://gerrit.cloudera.org:8080/#/c/3783/3/fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java File fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java: PS3, Line 2537: The given table must be a base table or a catalog view (not : * a local view). How is this enforced in this function? -- To view, visit http://gerrit.cloudera.org:8080/3783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18fa8af9a94ce190c5a3c29c3221c659a2ace659 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
