Michael Ho has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3791/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 2796: TestValue("CAST(' inf ' AS FLOAT)", TYPE_FLOAT, : numeric_limits<float>::infinity()); : TestValue("CAST(' inf ' AS DOUBLE)", TYPE_DOUBLE, : numeric_limits<double>::infinity()); This doesn't seem to match what you wrote in the comment. Isn't leading whitespace not acceptable ? May be I am missing something here. http://gerrit.cloudera.org:8080/#/c/3791/2/be/src/util/string-parser.h File be/src/util/string-parser.h: PS2, Line 438: !decimal Can you please add also a test case for it in expr-test (e.g. cast (1.2.3.4.5 as float)) ? Please feel free to ignore if you think it's redundant as I saw you also added tests for infinity and nan in end-to-end tests. -- To view, visit http://gerrit.cloudera.org:8080/3791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
