Michael Ho has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3791/3/be/src/util/string-parser.h File be/src/util/string-parser.h: PS3, Line 360: int i = 3; : if (i + 5 <= len && strncasecmp(s + i, "inity", 5) == 0) { : i += 5; : } Feel free to ignore as the compiler will have figured it out anyway. These lines may be simplified as: int i =3; if (len >= 8 && strncasecmp(s, "infinity", 8) == 0) i = 8; -- To view, visit http://gerrit.cloudera.org:8080/3791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
