Matthew Jacobs has posted comments on this change. Change subject: MPALA-1731,IMPALA-3868: Float values are not parsed correctly ......................................................................
Patch Set 4: (4 comments) Can you test the perf to make sure this doesn't regress significantly? You could write a few lines of code in a test case in a loop and time it before and after. http://gerrit.cloudera.org:8080/#/c/3622/4//COMMIT_MSG Commit Message: PS4, Line 7: MPALA IMPALA PS4, Line 12: strings like remove "strings like". These are the only strings. PS4, Line 12: Trailing leading too PS4, Line 16: Trailing leading too -- To view, visit http://gerrit.cloudera.org:8080/3622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
