Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3622/4//COMMIT_MSG Commit Message: PS4, Line 12: Trailing > Actually, StringParser class has two static functions that deal with float Ok, but that's not clear. Readers won't know about both here and will assume that is the user observable behavior. I don't even think it's necessary to talk about that specific detail here, so how about taking this bit about whitespace out of this commit message. I'll move over to the new ASF review if that helps. -- To view, visit http://gerrit.cloudera.org:8080/3622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
