Dan Hecht has posted comments on this change. Change subject: IMPALA-3376: Extra definition level when writing Parquet files ......................................................................
Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3556/7/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: PS7, Line 134: ParquetReader This isn't a parquet (file) reader, so how about renaming it ParquetLevelReader or similar. http://gerrit.cloudera.org:8080/#/c/3556/7/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: Line 165: bool buffer_full() const { return buffer_full_; } nit: how about moving this to line 181 to be adjacent with the other trivial accessors. -- To view, visit http://gerrit.cloudera.org:8080/3556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cafd7ef6b607ce6f815072b8af7395a892704d9 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
