David Knupp has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3782/2/tests/common/environ.py File tests/common/environ.py: Line 256: if impala_lzo_root is not None: > Sorry, I meant this function, _is_impalalzo_present() At the risk of seeming hopelessly obtuse, I'm not sure I follow. Since patch set 3, the indent error was fixed, and _is_impalalzo_present() returns only True or False. It never returns None. What am I missing? (Also, FWIW, I did just complete an exhaustive test run without LZO, and the build was successful.) -- To view, visit http://gerrit.cloudera.org:8080/3782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
