David Knupp has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. ......................................................................
Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/3782/4/tests/common/environ.py File tests/common/environ.py: PS4, Line 51: build_type_dir = build_type_arg_search_result.groups()[0].lower() > Whoops. Thanks. Heh. No problem. Line 168: def _set_impalad_build_type(self, die_name, die_producer): > Why the extra line? Oops. Sorry. Fixed. PS4, Line 251: > Based on what we found yesterday, the more accurate comment would be someth Done PS4, Line 260: > Based on what we found yesterday, a more accurate name for this would be so Done http://gerrit.cloudera.org:8080/#/c/3782/1/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: PS1, Line 40: @SkipIfS3.qualified_path > I looked at testdata/workloads/functional-query/queries/DataErrorsTest/hdfs Done Line 46: cls.TestMatrix.add_constraint(lambda v:\ > Yeah, seems like it's stale. Done http://gerrit.cloudera.org:8080/#/c/3782/2/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: PS2, Line 41: rrors(TestD > DataErrorsTest/hdfs-scan-node-errors.test, online 75, references LZO. Done -- To view, visit http://gerrit.cloudera.org:8080/3782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
