Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3842/2/be/src/exec/nested-loop-join-builder.cc File be/src/exec/nested-loop-join-builder.cc: Line 31: MemTracker* mem_tracker) : > i think the convention is to have the : on the new line as well Done http://gerrit.cloudera.org:8080/#/c/3842/2/be/src/exec/nested-loop-join-builder.h File be/src/exec/nested-loop-join-builder.h: Line 91: RowBatchList raw_build_batches_; > i still think raw is a misnomer and 'original' or 'input' is clearer. Done - changed to input. -- To view, visit http://gerrit.cloudera.org:8080/3842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d7608181eeacfe706a09c1e153d0a3e1ee9b475 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
