Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3842/1/be/src/exec/nested-loop-join-builder.h File be/src/exec/nested-loop-join-builder.h: Line 35: /// tuple memory, the non-copying mode is used and row batches are simply accumulated in > I was confused since I thought you were talking about the different memory that was my point, it also has a "non-data sink" interface. i understand that you can interchange the two calling conventions from the same caller, but that's in practice not done. anyway, let's leave it as-is, it doesn't really add much complexity. -- To view, visit http://gerrit.cloudera.org:8080/3842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d7608181eeacfe706a09c1e153d0a3e1ee9b475 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
