Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3924: Ubuntu16 support ......................................................................
IMPALA-3924: Ubuntu16 support One problem uncovered while trying to build Impala on Ubuntu16 is that the functions 'isnan' and 'isinf' both appear in std:: (from <cmath>) and in boost::math::, but we're currently using them without qualifiers in several places, leading to a conflict. This patch prefaces all uses with 'std::' to disambiguate, and also adds <cmath> imports to all files that use those functions, for the sake of explicitness. Another problem is that bin/make_impala.sh uses the system cmake, which may not be compatible with the toolchain binaries. This patch updates impala-config.sh to add the toolchain cmake to PATH, so that we'll use it wherever we use cmake. Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a Reviewed-on: http://gerrit.cloudera.org:8080/3800 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Internal Jenkins --- M be/src/exprs/cast-functions-ir.cc M be/src/exprs/udf-builtins-ir.cc M be/src/runtime/raw-value-ir.cc M be/src/runtime/raw-value.inline.h M be/src/util/metrics-test.cc M bin/bootstrap_toolchain.py M bin/impala-config.sh 7 files changed, 32 insertions(+), 23 deletions(-) Approvals: Matthew Jacobs: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
