Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3924: Ubuntu16 support
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3800/5/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

Line 342:   packages = ["avro", "binutils", "boost", "breakpad", "bzip2", 
"cmake", "gcc", "gflags", "glog",
long line


http://gerrit.cloudera.org:8080/#/c/3800/5/bin/impala-config.sh
File bin/impala-config.sh:

Line 310: export 
PATH=$IMPALA_HOME/bin:$IMPALA_TOOLCHAIN/cmake-$IMPALA_CMAKE_VERSION/bin/:$PATH
I'm not a big fan of dumping everything into the developer's shell, but I think 
that ship sailed a long time ago and this seems unlikely to have any bad 
consequences.


-- 
To view, visit http://gerrit.cloudera.org:8080/3800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa1520c1e4aa4175468ac342b14c1262fa745f7a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to