Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3952: Clear scratch batch mem pool if Open() failed. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3953/1//COMMIT_MSG Commit Message: PS1, Line 11: pts ptrs http://gerrit.cloudera.org:8080/#/c/3953/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS1, Line 210: else if (!FLAGS_enable_partitioned_hash_join || : !FLAGS_enable_partitioned_aggregation) { Not necessarily an issue, but it might be better to just execute this branch whenever row_batch is NULL since the behavior is more predictable and there will be cases where we free scratch_batch_ even when it's "not required" anyway, e.g. if PHJ is enabled but not PAgg, or visa versa. Or e.g. we specified do not enable PHJ but you used an anti join so we spin up the PHJ regardless. PS1, Line 212: pts ptrs -- To view, visit http://gerrit.cloudera.org:8080/3953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55f32ed698a5b6fed8c28af1391aa07e1560e782 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
