Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3952: Clear scratch batch mem pool if Open() failed. ......................................................................
IMPALA-3952: Clear scratch batch mem pool if Open() failed. We used to be able to hit a DCHECK in HdfsParquetScanner::Close() when using the legacy aggs/joins if HdfsParquetScanner::Open() failed. With the legacy aggs/joins the tuple ptrs of the scratch batch are allocated from the scratch batch's mem pool, and if Open() failed we never freed or transferred the scratch batch's mem pool. Testing: I tested this patch together with the fix for IMPALA-3964 on core/hdfs with the legacy aggs and joins enabled. Change-Id: I55f32ed698a5b6fed8c28af1391aa07e1560e782 Reviewed-on: http://gerrit.cloudera.org:8080/3953 Reviewed-by: Alex Behm <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/hdfs-parquet-scanner.cc 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f32ed698a5b6fed8c28af1391aa07e1560e782 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]>
