Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only ......................................................................
Patch Set 7: Code-Review+2 (2 comments) Please also let Marcel finish his review. http://gerrit.cloudera.org:8080/#/c/3688/7/be/src/bufferpool/buffer-pool.h File be/src/bufferpool/buffer-pool.h: PS7, Line 124: free up memory reservations this instance wasn't updated to be clearer on terminology: decreases reservation usage PS7, Line 217: frees also not updated: decreases reservation usage -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
