Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only ......................................................................
Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3688/7/be/src/bufferpool/buffer-pool.h File be/src/bufferpool/buffer-pool.h: Line 218: /// reservation in 'src_client'. 'src' must be open and 'dst' must be closed before > how do you get a closed BufferHandle, other than calling allocate and free we can decide to change this later, if the code that calls this ends up looking awkward, i just wanted to point this out as something odd. -- To view, visit http://gerrit.cloudera.org:8080/3688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id771dea2eb4c1aa13c30d59e8b184a7d1bca8d34 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
