Tim Armstrong has posted comments on this change. Change subject: IMPALA-3981: Fixed the bug of "Crash when access statestore/catalog memz webpage" ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3998/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: Line 112: No need to add the extra line. Line 114: if(ExecEnv::GetInstance()!= NULL){ Need extra whitespace. if (ExecEnv::GetInstance() != NULL) { Line 115: ExecEnv::GetInstance()->metrics()->GetChildGroup("jvm")->ToJson(false, document, &jvm); Long line - wrap it before &jvm Line 117: for(SizeType i = 0; i < jvm["metrics"].Size(); ++i){ Missing spaces here from before the change: for (SizeType i = 0; i < jvm["metrics"].Size(); ++i) { Line 118: if (strstr(jvm["metrics"][i]["name"].GetString(), "total") != nullptr){ Missing space before { -- To view, visit http://gerrit.cloudera.org:8080/3998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
