Kathy Sun has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3998/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: PS2, Line 428: AddDefaultUrlCallbacks > Hmm... ok, but why to change it this way? At patch3 I change the catalogd as you described temporarily, is this same as what you think? http://gerrit.cloudera.org:8080/#/c/3998/2/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: Line 113: MetricGroup* JvmGroup = metric_group->GetChildGroup("jvm"); > May I ask should we check if exist first...? Forget my two plans here.. I was being silly. Now I get it. PS2, Line 114: (JvmGroup != NULL) > this will never happen when using GetChildGroup(), see above comment. Done -- To view, visit http://gerrit.cloudera.org:8080/3998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
