Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors ......................................................................
Patch Set 1: (3 comments) Does hdfs-rcfile-scan-node-errors.test need updates as well? http://gerrit.cloudera.org:8080/#/c/4020/1//COMMIT_MSG Commit Message: Line 7: IMPALA-(3895,3859): Don't log file data on parse errors IMPALA-1872 too? or more needed? I guess we can use that JIRA to remove SkipIfS3.qualified_path which seems like it should be possible now. PS1, Line 16: __DFS_FILENAME__ This works for s3a and file scheme as well, right? So how about calling it __HDFS_FILENAME__ or __FILENAME__ instead (for better or worse, HDFS has come to mean Hadoop FileSystem in many context, whereas DFS always means distributed filesystem)? Also, how does one choose whether to use $NAMENODE/path/to/file vs. __DFS_FILENAME__ in new tests? http://gerrit.cloudera.org:8080/#/c/4020/1/testdata/workloads/functional-query/queries/QueryTest/parquet-continue-on-error.test File testdata/workloads/functional-query/queries/QueryTest/parquet-continue-on-error.test: PS1, Line 84: : why is it : here but = above? -- To view, visit http://gerrit.cloudera.org:8080/4020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
