Henry Robinson has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4020/2/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: PS2, Line 624: const string& s > A string reference seems wrong here - where is the string it's referencing This is a reference to the temporary returned by Substitute. C++ requires that const references to temporaries extend the lifetime of the temporary to that of the reference. I think this can save a copy, although I'm not totally sure whether RVO does that already. -- To view, visit http://gerrit.cloudera.org:8080/4020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
