Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail ......................................................................
IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail HdfsTableSink::Close() makes calls to functions that can fail with a Status. However, since the function has a void return type, these error statuses are just logged and we cannot take any action according to the type of error. This patch moves the closing of the partition file into the FlushFinal function from Close(), so that in case of an error on closing the file, the error is propagated up and some action can be taken. We try and close all the partition files in the map in Close() as well because if a query is cancelled, FlushFinal will not be called and we would end up leaking some file descriptors. Also fixed some long lines in this patch. Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b --- M be/src/exec/hdfs-table-sink.cc M be/src/exec/hdfs-table-sink.h 2 files changed, 16 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4018/2 -- To view, visit http://gerrit.cloudera.org:8080/4018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]>
