Sailesh Mukil has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4018/1/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 648: } > MergeStatus() does this check for you. I misunderstood the working of the ClosePartitionFile() function. So I removed the erase from the map now as it wouldn't save us too much. Line 653: void HdfsTableSink::Close(RuntimeState* state) { > why can't this stay in Close() so that it can more easily always happen, gi Done -- To view, visit http://gerrit.cloudera.org:8080/4018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2546bc68ba136b2713d744c1b920878606a2217b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
