Kathy Sun has posted comments on this change. Change subject: IMPALA-3981: Fix crash when accessing statestored / catalogd /memz page ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3998/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 326: ImpaladMetrics::CreateMetrics( > long line Done http://gerrit.cloudera.org:8080/#/c/3998/5/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: PS5, Line 117: ++i > revert this to ++i please Done http://gerrit.cloudera.org:8080/#/c/3998/5/be/src/util/metrics-test.cc File be/src/util/metrics-test.cc: Line 228: > Can you add a quick test for FindChildGroup? Done http://gerrit.cloudera.org:8080/#/c/3998/5/www/memz.tmpl File www/memz.tmpl: Line 60: > nit: remove blank line Done -- To view, visit http://gerrit.cloudera.org:8080/3998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If59b10f20044d1a468f27810a3029fe18fb19f29 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
