Henry Robinson has posted comments on this change. Change subject: IMPALA-3988: Only use first 104 bits of query id ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4065/2/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: PS2, Line 512: CreateInstanceId(schedule->query_id(), instance_idx, &instance_id); > this way it's easier to change the layout, if that should ever be needed. a I don't think it's any easier to change they layout (is the method ever used anywhere else?). But I don't feel too strongly. http://gerrit.cloudera.org:8080/#/c/4065/2/be/src/util/uid-util.h File be/src/util/uid-util.h: PS2, Line 62: void > we typically only return scalars Not always - see MakeNetworkAddress(), or GenerateUUID() in this file for examples where we don't. TUniqueIds are 128-bits, and should always be in registers, plus RVO can probably elide a copy. If you return TUniqueId, the code becomes easier to read because you don't separate variable declaration and initialisation. -- To view, visit http://gerrit.cloudera.org:8080/4065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
