Henry Robinson has posted comments on this change.

Change subject: IMPALA-3988: Only use first 104 bits of query id
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4065/2//COMMIT_MSG
Commit Message:

PS2, Line 9: This adds utility function in uid-util.h to create query and 
instance ids and convert between them.
           : It also adapts SimpleScheduler to utilize those functions when 
creating the instance id
           : (TPlanFragmentInstanceCtx.fragment_instance_id).
> this is a weird line limit, where did this come from?
90 chars? 

We often stick to 80 for commit messages because some tools expect them. But 
line 9 is > 90 chars.


-- 
To view, visit http://gerrit.cloudera.org:8080/4065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to