Dan Hecht has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend ......................................................................
Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/4054/3//COMMIT_MSG Commit Message: PS3, Line 13: enventual typo http://gerrit.cloudera.org:8080/#/c/4054/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS3, Line 405: = space before PS3, Line 407: is_mt_execution is_mt_exec for consistency above PS3, Line 408: is_mt_execution why is this only needed for MT? PS3, Line 443: = space PS3, Line 1158: (Instances have a sink only if the coordinator does not) is that true? PS3, Line 1441: TODO TODO-MT? PS3, Line 1446: r nit: would be nice to capitalize and punctuate comments that are sentences. Line 1469: // Note: we don't start the wall timer here for the fragment weird early line break -- To view, visit http://gerrit.cloudera.org:8080/4054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I240445199e22f009f4e72fdb8754eb8d77e3d680 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
