Alex Behm has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4054/3/fe/src/main/java/com/cloudera/impala/service/Frontend.java File fe/src/main/java/com/cloudera/impala/service/Frontend.java: Line 964: planner.computeResourceReqs(fragments, true, queryExecRequest); > anything llama-related is going to be removed for the next release. i'll le so we are going to remove the resource estimates reported in the explain plan altogether? you might be surprised that some users rely on them Line 1042: for (int idx = 0; idx < fragments.size(); ++idx) { > all of the non-mt paths (meaning the functions for which this patch creates Fair enough, but I don't see the old code going away anytime soon (i.e. several quarters). We can refactor later if the maintenance does become a problem. -- To view, visit http://gerrit.cloudera.org:8080/4054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I240445199e22f009f4e72fdb8754eb8d77e3d680 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
