Christopher Channing has posted comments on this change. Change subject: IMPALA-3938: Disallow implicit references between nested collections. ......................................................................
Patch Set 2: (4 comments) Done http://gerrit.cloudera.org:8080/#/c/4079/2/fe/src/main/java/com/cloudera/impala/analysis/Path.java File fe/src/main/java/com/cloudera/impala/analysis/Path.java: Line 227: && isOptionalFieldCollectionType((CollectionStructType)structType); > Based on this latest version I think the code can be simplified to not even Done http://gerrit.cloudera.org:8080/#/c/4079/2/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java: Line 597: // Test implicit key/value reference is not abused when using a map within an array. > can you explain which resolution is not allowed? Done Line 598: addTestTable("create table d.t9 (c1 array<map<string, string>>)"); > nit: use 'c' instead of 'c1' for consistency with the other tests Based on the comment below I've left this as c1 and added a new column c2 (adhered to the tests above). Line 599: AnalysisError("select key from d.t9.c1", > add similar tests for a map nested inside a map (we can run into the same i As discussed, I've added a map<string, array<struct>> -- To view, visit http://gerrit.cloudera.org:8080/4079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703c7e9c8c9c95c9fee714767367373eec10cd0c Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Christopher Channing <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Christopher Channing <[email protected]> Gerrit-HasComments: Yes
