Alex Behm has posted comments on this change. Change subject: IMPALA-3938: Disallow implicit references between nested collections. ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4079/3/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java: Line 578: // Tests that an attempted implicit match must be succeeded by an explicit match. Please adjust this comment. It is no longer accurate after your changes. Same for the comments in this test cluster below. This is basically the same case as the one you fixed below (implicit references cannot go through collections) Line 589: // - however, we are not allowed to implicitly skip 'item' again, since we have Please adjust this comment also. Line 591: // - the rule is: an implicit match must be followed by an explicit one Please adjust this comment also. What is the rule? Line 594: AnalysisError("select 1 from d.t8.s1.s2.a, a.f", you could you add a few tests below that are similar to this? i.e, the invalid reference is in the FROM clause Line 597: // Test to validate that implicit references between collection types cannot be used. Tests that implicit references are not allowed through collection types. -- To view, visit http://gerrit.cloudera.org:8080/4079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703c7e9c8c9c95c9fee714767367373eec10cd0c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Christopher Channing <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Christopher Channing <[email protected]> Gerrit-HasComments: Yes
