Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3394: Add tests, make BackendConfig own class, refactor ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4116/2/be/src/scheduling/backend-config-test.cc File be/src/scheduling/backend-config-test.cc: Line 32: vector<TNetworkAddress> backends { (MakeNetworkAddress("localhost", 1001)) }; can you check the google style guide whether the {} require spaces? http://gerrit.cloudera.org:8080/#/c/4116/1/be/src/util/network-util.h File be/src/util/network-util.h: Line 55: TBackendDescriptor MakeBackendDescriptor(const Hostname& hostname, const IpAddr& ip, > I tried to follow the surrounding code here. IMO changing this to an output leave it in. we'll need to come up with some coherent guidelines. -- To view, visit http://gerrit.cloudera.org:8080/4116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3acb6f68b16ca0af06dad0098d7ec1eff41202 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
