Lars Volker has posted comments on this change. Change subject: IMPALA-3394: Add tests, make BackendConfig own class, refactor ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4116/2/be/src/scheduling/backend-config-test.cc File be/src/scheduling/backend-config-test.cc: Line 32: vector<TNetworkAddress> backends {MakeNetworkAddress("localhost", 1001)}; > can you check the google style guide whether the {} require spaces? Google says they should be optional. I grepped through be/src and we use both styles as well, though omitting them seems to be more common. Removed them. https://google.github.io/styleguide/cppguide.html#Horizontal_Whitespace // Spaces inside braces for braced-init-list are optional. If you use them, // put them on both sides! int x[] = { 0 }; -- To view, visit http://gerrit.cloudera.org:8080/4116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3acb6f68b16ca0af06dad0098d7ec1eff41202 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
