Dan Burkert has posted comments on this change. Change subject: IMPALA-3481: Use Kudu ScanToken API for scan ranges ......................................................................
Patch Set 1: (3 comments) ScanToken usage LGTM. I agree with Todd that we should provide some more debug printing tools if you all need it. http://gerrit.cloudera.org:8080/#/c/4120/1/be/src/exec/kudu-scan-node.h File be/src/exec/kudu-scan-node.h: PS1, Line 76: string not sure if y'all follow the same style guide, but this should be std::string here and below. Line 79: int next_scan_token_idx_; I may have missed something, but it looks like you could just use scan_tokens_ as a stack and pop tokens off it for each call to GetNextScanToken. http://gerrit.cloudera.org:8080/#/c/4120/1/fe/src/test/java/com/cloudera/impala/planner/PlannerTestBase.java File fe/src/test/java/com/cloudera/impala/planner/PlannerTestBase.java: PS1, Line 281: KUDU KEYRANGE > KEYRANGE isn't really accurate -- this makes it seem like it's a primary ke Moreover, I think the important thing here isn't the partition key range, but what tablet it's scanning. I recommend just printing the tablet ID. -- To view, visit http://gerrit.cloudera.org:8080/4120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I160e5849d372755748ff5ba3c90a4651c804b220 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
