Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3481: Use Kudu ScanToken API for scan ranges ......................................................................
Patch Set 1: (3 comments) Thanks for the feedback. Just responding to the plan info issue now. Will fix everything else later. http://gerrit.cloudera.org:8080/#/c/4120/1//COMMIT_MSG Commit Message: Line 36: work), add TPC-DS tests that demonstrate pruning. > I think the pruning isn't quite working on the Kudu side quite yet. You can Ah ok, thanks. http://gerrit.cloudera.org:8080/#/c/4120/1/fe/src/test/java/com/cloudera/impala/planner/PlannerTestBase.java File fe/src/test/java/com/cloudera/impala/planner/PlannerTestBase.java: PS1, Line 281: KUDU KEYRANGE > Moreover, I think the important thing here isn't the partition key range, b @Dimitris, yup. @Todd/Dan, yeah, we'd ideally like to get a sense of what data is going to be scanned. I can change the name for now. Line 297: result.append(Arrays.toString(upperBound.toByteArray())); > maybe we should provide you a nicer toString() type method you can use? In Yes, a toString() method would be very handy. Shall I file a JIRA? In the meantime I guess we can keep this though, assuming we switch over to using a new toString() method or such before we ship- seem reasonable? We just need some way to verify the plans. -- To view, visit http://gerrit.cloudera.org:8080/4120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I160e5849d372755748ff5ba3c90a4651c804b220 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
