Lars Volker has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4094/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 312: std::basic_string<uint8_t> haystack(str.ptr); > No, std::string is signed, therefore I would need to apply a reinterpret_ca Can you add this in a comment? http://gerrit.cloudera.org:8080/#/c/4094/2/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS2, Line 306: int search_start_pos = backwards ? : str.len + start_position.val : : start_position.val - 1; line wrapping http://gerrit.cloudera.org:8080/#/c/4094/1/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: PS1, Line 65: str > I wrapped the parameters this way intentionally, as the two string paramete Here's a list of exceptions to the Google C++ style guide, that we stick to: https://wiki.cloudera.com/pages/viewpage.action?pageId=24646528 Sadly it hasn't been ported to the apache wiki yet, but it's the authoritative information on the subject. While I understand that personal style is often perceived as more readable, we prefer consistency of the code and thus usually wrap lines by the same rules, independent of the parameter semantics. -- To view, visit http://gerrit.cloudera.org:8080/4094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9648de458d243306fa14adc5e7f7002bf6f67fd Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
