Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4094/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 312: std::basic_string<uint8_t> haystack(str.ptr); > Can you add this in a comment? Done http://gerrit.cloudera.org:8080/#/c/4094/2/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS2, Line 306: str.len + start_position.val : : // Position count starts from 1, not 0. : start_position.val - 1; > line wrapping Done http://gerrit.cloudera.org:8080/#/c/4094/1/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: PS1, Line 65: str > Here's a list of exceptions to the Google C++ style guide, that we stick to Done -- To view, visit http://gerrit.cloudera.org:8080/4094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9648de458d243306fa14adc5e7f7002bf6f67fd Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
