Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3725 Support Kudu UPSERT in Impala
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4047/1//COMMIT_MSG
Commit Message:

PS1, Line 22: all of the columns in table_name
> This was Matt's suggestion. We don't currently know what the primary key co
The original point of this was to do the simplest thing until we had support 
for nullable columns, at which point we expected the code to change -- i.e. to 
avoid wasted work. However, as we've discussed, we now want to see if Kudu will 
just leave non-referenced columns as-is, and error on violations itself (and we 
handle them gracefully).


-- 
To view, visit http://gerrit.cloudera.org:8080/4047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8df5cea36b642e267f85ff6b163f3dd96b8386e9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-HasComments: Yes

Reply via email to