Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala ......................................................................
Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/4047/1//COMMIT_MSG Commit Message: PS1, Line 22: all of the columns in table_name > The original point of this was to do the simplest thing until we had suppor Done http://gerrit.cloudera.org:8080/#/c/4047/1/fe/src/main/java/com/cloudera/impala/analysis/InsertStmt.java File fe/src/main/java/com/cloudera/impala/analysis/InsertStmt.java: PS1, Line 447: All columns if this is an UPSERT. > See my comment in the commit msg. I am not sure this restriction is correct Done PS1, Line 689: !isUpsert_ > flip the conditions to avoid using a negative, just easier to read Done http://gerrit.cloudera.org:8080/#/c/4047/2/fe/src/main/java/com/cloudera/impala/analysis/InsertStmt.java File fe/src/main/java/com/cloudera/impala/analysis/InsertStmt.java: PS2, Line 445: ars > typo Done PS2, Line 447: * - All columns if this is an UPSERT. > As discussed, if Kudu leaves non-referenced columns as-is, then let's remov Done PS2, Line 689: if (!isUpsert_) { : strBuilder.append("INSERT "); : } else { : strBuilder.append("UPSERT"); : } > Flip the logic; easier to read when, all else being equal, there are fewer Done http://gerrit.cloudera.org:8080/#/c/4047/2/testdata/workloads/functional-planner/queries/PlannerTest/insert.test File testdata/workloads/functional-planner/queries/PlannerTest/insert.test: PS2, Line 524: : : : : : : : > not needed, remove Done PS2, Line 541: : : : : : : > same Done PS2, Line 560: : : : : : : : : : : : > same Done -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df5cea36b642e267f85ff6b163f3dd96b8386e9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
