Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() ......................................................................
Patch Set 4: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/4125/4/fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java File fe/src/main/java/com/cloudera/impala/common/FileSystemUtil.java: Line 379: public static boolean copyToLocal(Path source, Path dest, StringBuilder errorTrace) { > Same here. - Yea, now that I think about it, it sounds weird to me too. I changed copyToLocal() to throw an exception. - However I didn't do it for isPathReachable() as its callers seem to be relying on this behavior. Ideally I could refactor them, but other statements in their try-catch blocks also throw the same IOException. So again it would be nested try catch with both blocks catching same IOE. It makes that section a little unreadable and hence I didn't make the change. Please let me know what you think. -- To view, visit http://gerrit.cloudera.org:8080/4125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Brock Noland <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
