Alex Behm has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() ......................................................................
Patch Set 6: (4 comments) Will give +2 once final comments are addressed. http://gerrit.cloudera.org:8080/#/c/4125/6//COMMIT_MSG Commit Message: Line 9: Currently the code swallows the actual exception incase the call modify to reflect current patchset http://gerrit.cloudera.org:8080/#/c/4125/6/fe/src/main/java/com/cloudera/impala/analysis/HdfsUri.java File fe/src/main/java/com/cloudera/impala/analysis/HdfsUri.java: Line 91: StringBuilder errorMsg = new StringBuilder(); remove Line 93: analyzer.addWarning(String.format("Path '%s' cannot be reached: %s", Cannot be reached sounds somewhat ambiguous now. How about "Path does not exist" The other case of cannot be reached will now fail with an exception, so there is a slight behavioral change that I think is fine. http://gerrit.cloudera.org:8080/#/c/4125/6/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: Line 86: StringBuilder errorMsg = new StringBuilder(); remove -- To view, visit http://gerrit.cloudera.org:8080/4125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5664a75aa837951de1d5dcc90e43bd8f313736b8 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Brock Noland <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
