Tim Armstrong has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 262: RETURN_IF_ERROR(HdfsParquetScanner::IssueInitialRanges(this, Is the order important? Would be helpful to have a comment here if there is some significance. Line 740: runtime_state_->resource_pool()->set_max_quota(CpuInfo::num_cores() + 1); Doesn't this number also include async join build threads? It might be easier to reason about if we instead use the same code path as the num_scanner_threads query option. -- To view, visit http://gerrit.cloudera.org:8080/4174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I191988ad18d6b4caf892fc967258823edcf9681f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
