Tim Armstrong has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 740: runtime_state_->resource_pool()->set_max_quota(CpuInfo::num_cores() + 1); > Doesn't this number also include async join build threads? Nm, you are already doing that. It seems weird that the scanner threads quota is set at the fragment level. I think either both should have the + 1 or neither. It's weird that this has the same effect as setting num_scanner_threads=(num_cores() + 1) -- To view, visit http://gerrit.cloudera.org:8080/4174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I191988ad18d6b4caf892fc967258823edcf9681f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
